LGTM
There is usually a penalty associated with corrupting the return stack
predictor. That is, making a call (blr) should usually have a corresponding
return (ret) to the call site. However, we didn't do that correctly before
this
patch anyway, so I don't think this patch will make any difference.
It might be nice if we could pass `entry_offset` to `deopt_entry` as a
proper
parameter, but it's probably not terribly important, and making a
machine-specific exception to the way that they're handled would be a bit
ugly.
If we're deoptimising, we're already not on the fast path.
https://codereview.chromium.org/984893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
