lgtm
https://codereview.chromium.org/987353002/diff/1/src/isolate.cc
File src/isolate.cc (left):
https://codereview.chromium.org/987353002/diff/1/src/isolate.cc#oldcode1470
src/isolate.cc:1470: MessageLocation Isolate::GetMessageLocation() {
On 2015/03/10 13:45:07, Michael Starzinger wrote:
Please appreciate the fact that I can put UNREACHABLE() into this
method and
still pass the entire test suite. That for sure instills confidence in
our test
coverage.
Yeah, given that you showed me that this is only called in LiveEdit,
then it must not be critical enough that someone bothered testing it.
https://codereview.chromium.org/987353002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
