On 2015/03/10 13:36:20, jochen (slow) wrote:
the code changes lgtm. But won't that break all the gn builders on the v8
waterfall if it depends on a chrome side change?
+machenbach for rolling question
+dpranke because he looked into that before
Indeed it will. I was hoping that I could do the DEPs roll and land
https://codereview.chromium.org/988183003 in one patch. If you think that's
a
bad idea, then I can do the following:
. land a patch in the chrome side that adds a variable as to whether the
code
path in this patch should be enabled. Say enable_correct_v8_arch in
build/module_args/v8.gni. The patch I land now would set it to false.
. land this patch in the v8 side.
. roll deps.
. Land https://codereview.chromium.org/988183003 and include in it setting
enable_correct_v8_arch to true.
. Land patch in v8 side that removes enable_correct_v8_arch.
. roll deps
. Land patch in chrome side that removes enable_correct_v8_arch.
UGH! This is the safest approach, but the most pain. WDYT?
Of course I need to land https://codereview.chromium.org/984353002/ before
any
of this.
https://codereview.chromium.org/991023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
