https://codereview.chromium.org/990423004/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/990423004/diff/20001/src/heap/heap.cc#newcode2235
src/heap/heap.cc:2235: heap->set_migration_failure(false);
On 2015/03/10 14:56:14, ulan wrote:
Where is migration_failure set to true?

here. that was a manual merge conflict error.

https://codereview.chromium.org/990423004/diff/20001/src/heap/objects-visiting.cc
File src/heap/objects-visiting.cc (right):

https://codereview.chromium.org/990423004/diff/20001/src/heap/objects-visiting.cc#newcode289
src/heap/objects-visiting.cc:289: if (view != undefined && record_slots)
{
On 2015/03/10 14:56:14, ulan wrote:
view should never be undefined here.

Correct, removed.

https://codereview.chromium.org/990423004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to