Would it not make more sense to track that we are inside the
method/accessor of
a class instead of tracking when we are in an object literal outside a
class?
https://codereview.chromium.org/994043003/diff/60001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/994043003/diff/60001/src/hydrogen-instructions.h#newcode7584
src/hydrogen-instructions.h:7584: class PretenureField : public
BitField<bool, 8, 1> {};
Maybe use kNext here?
https://codereview.chromium.org/994043003/diff/60001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/994043003/diff/60001/src/preparser.h#newcode2185
src/preparser.h:2185: if (!in_class) kind = WithObjectLiteralBit(kind);
It is not clear to me that we need this extra bit. Why do we need to
distinguish if the accessor is part of a ClassLiteral vs ObjectLiteral?
https://codereview.chromium.org/994043003/diff/60001/test/mjsunit/strong/declaration-after-use.js
File test/mjsunit/strong/declaration-after-use.js (right):
https://codereview.chromium.org/994043003/diff/60001/test/mjsunit/strong/declaration-after-use.js#newcode167
test/mjsunit/strong/declaration-after-use.js:167: "if (false) {\n" +
unindent
https://codereview.chromium.org/994043003/diff/60001/test/mjsunit/strong/declaration-after-use.js#newcode167
test/mjsunit/strong/declaration-after-use.js:167: "if (false) {\n" +
unindent
https://codereview.chromium.org/994043003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
