Reviewers: arv, Dmitry Lomov (chromium), marja,
Message:
Alternative version of https://crrev.com/987083003 --- this one doesn't
change
the parser to incorporate an extra lookahead token (which _may_ be
preferable).
Some issues:
- preparser is never able to figure out if arrow functions contain
duplicate
parameters, which (I think?) prevents test-parsing from doing much good when
errors are expected.
- right now, `var x = (...a);` is not an error. It should be, but using
this
strategy I'm not sure yet how to make sure it's treated as an error.
- the errors you do get are generally not showing very helpful text
I think the version which relies on an extra lookahead is probably a better
option, but think about it
Description:
[es6] support rest parameters in arrow functions (alternative)
BUG=v8:2159
LOG=N
[email protected], [email protected], [email protected]
Please review this at https://codereview.chromium.org/997823003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+206, -42 lines):
M src/ast.h
M src/ast-numbering.cc
M src/compiler/ast-graph-builder.cc
M src/compiler/ast-loop-assignment-analyzer.cc
M src/full-codegen.cc
M src/hydrogen.cc
M src/parser.h
M src/parser.cc
M src/preparser.h
M src/preparser.cc
M src/prettyprinter.cc
M src/typing.cc
M test/cctest/test-parsing.cc
M test/mjsunit/harmony/rest-params.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
