On 2015/03/11 12:03:50, balazs.kilvady wrote:
https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mips.cc#newcode365
src/mips/lithium-codegen-mips.cc:365: __ push(at);
On 2015/03/10 19:32:41, loislo wrote:
> Would it be more effective to move ra from upper MultiPush to here?
ra must be saved before the Call() as Call() overrides ra. The upper
MultiPush()
is the exact port of arm PushFixedFrame().
https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mips.cc#newcode380
src/mips/lithium-codegen-mips.cc:380: __ Call(entry_offset);
On 2015/03/10 19:32:41, loislo wrote:
> there should be a Branch otherwise we will have two frames instead of
one.
Thank you for catching this. Fix is Done.
lgtm from my side.
https://codereview.chromium.org/996883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
