Reviewers: danno, Sven Panne,
Message:
Next incremental change required for PPC
Description:
cctest/test-deoptimization/DeoptimizeCompare was failing on PPC because the
path
that is optimized for isel incorrectly used integer values instead of Smi's
BUG=
Please review this at https://codereview.chromium.org/996223002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -3 lines):
M src/ppc/code-stubs-ppc.cc
M test/cctest/cctest.status
Index: src/ppc/code-stubs-ppc.cc
diff --git a/src/ppc/code-stubs-ppc.cc b/src/ppc/code-stubs-ppc.cc
index
635a7fc9e6b0e067e348e94d2617bc68cf31b4cd..c4b8af05cba6c32a3d4fda8a6b590025370010a6
100644
--- a/src/ppc/code-stubs-ppc.cc
+++ b/src/ppc/code-stubs-ppc.cc
@@ -3563,8 +3563,8 @@ void StringHelper::GenerateCompareFlatOneByteStrings(
// Conditionally update the result based either on length_delta or
// the last comparion performed in the loop above.
if (CpuFeatures::IsSupported(ISELECT)) {
- __ li(r4, Operand(GREATER));
- __ li(r5, Operand(LESS));
+ __ LoadSmiLiteral(r4, Smi::FromInt(GREATER));
+ __ LoadSmiLiteral(r5, Smi::FromInt(LESS));
__ isel(eq, r3, r0, r4);
__ isel(lt, r3, r5, r3);
__ Ret();
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index
489d6f97e04ef798b509fe32ab1f14d5906dc084..f278b058b74887af3b6a627aac4af97ad181175c
100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -407,7 +407,6 @@
# issues to be investigated based on latest uplevel
'test-run-machops/RunWord64EqualInBranchP': [SKIP],
- 'test-deoptimization/DeoptimizeCompare': [SKIP],
# will not pass until we agree/implement changes to serializce.cc
'test-serialize/SerializeInternalReference': [SKIP],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
