LGTM, but you need to fix that name...

http://codereview.chromium.org/391079/diff/2003/3003
File src/ia32/codegen-ia32.h (right):

http://codereview.chromium.org/391079/diff/2003/3003#newcode474
Line 474: void LoadUnsafeSmi(int offset, Handle<Object> value);
This seems like pretty unfortunate overloading. Isn't it really more
like StoreUnsafeSmiInLocal?

http://codereview.chromium.org/391079

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to