https://codereview.chromium.org/997823003/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/997823003/diff/1/src/preparser.h#newcode2005
src/preparser.h:2005: case Token::ELLIPSIS:
Beware of fall through here.

https://codereview.chromium.org/997823003/diff/1/src/preparser.h#newcode2406
src/preparser.h:2406: // TODO(caitp): the error is an unexpected `...`,
it would be nice if we
Can you store the position before calling ParseConditionalExpression?

https://codereview.chromium.org/997823003/diff/1/src/preparser.h#newcode2416
src/preparser.h:2416: // TODO(caitp): report an error if an unexpected
`...` occurred.
Here it would be good to have an ast ;-)

I'm not really sure how to best track this. Potentially we could pass in
a Location pointer but it gets ugly.

https://codereview.chromium.org/997823003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to