Reviewers: Lasse Reichstein, Description: Add missing case for shr in IA-32 disassembler
Please review this at http://codereview.chromium.org/397024 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/ia32/disasm-ia32.cc M test/cctest/test-disasm-ia32.cc Index: test/cctest/test-disasm-ia32.cc =================================================================== --- test/cctest/test-disasm-ia32.cc (revision 3314) +++ test/cctest/test-disasm-ia32.cc (working copy) @@ -201,6 +201,7 @@ __ shl(edx, 6); __ shl_cl(edx); __ shrd(edx, Operand(ebx, ecx, times_4, 10000)); + __ shr(edx, 1); __ shr(edx, 7); __ shr_cl(edx); Index: src/ia32/disasm-ia32.cc =================================================================== --- src/ia32/disasm-ia32.cc (revision 3313) +++ src/ia32/disasm-ia32.cc (working copy) @@ -540,8 +540,9 @@ imm8 = 1; switch (regop) { case edx: mnem = "rcl"; break; + case esp: mnem = "shl"; break; + case ebp: mnem = "shr"; break; case edi: mnem = "sar"; break; - case esp: mnem = "shl"; break; default: UnimplementedInstruction(); } } else if (op == 0xC1) { --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
