Reviewers: alph, loislo, Yang,
Description:
Remove obsolete TakeHeapSnapshot method from API
BUG=chromium:465651
LOG=Y
Please review this at https://codereview.chromium.org/997583004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -16 lines):
M include/v8-profiler.h
M src/api.cc
Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index
56b8e02616a2d4594a1cb606c91cfd718e1fe920..173849e0cd96a5d8a7c8d9b14359e8e84a56178e
100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -447,16 +447,9 @@ class V8_EXPORT HeapProfiler {
};
/**
- * Takes a heap snapshot and returns it. Title parameter is deprecated
and
- * should be an empty string.
- * TODO: deprecate this method.
+ * Takes a heap snapshot and returns it.
*/
const HeapSnapshot* TakeHeapSnapshot(
- Handle<String> title,
- ActivityControl* control = NULL,
- ObjectNameResolver* global_object_name_resolver = NULL);
-
- const HeapSnapshot* TakeHeapSnapshot(
ActivityControl* control = NULL,
ObjectNameResolver* global_object_name_resolver = NULL);
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
f285980f6b654d289e82f62bd4963b3c1ccab1a9..eef9e508240da9e9c6e580d6247c83437292b9e6
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -7689,14 +7689,6 @@ void HeapProfiler::ClearObjectIds() {
const HeapSnapshot* HeapProfiler::TakeHeapSnapshot(
- Handle<String> title,
- ActivityControl* control,
- ObjectNameResolver* resolver) {
- return TakeHeapSnapshot(control, resolver);
-}
-
-
-const HeapSnapshot* HeapProfiler::TakeHeapSnapshot(
ActivityControl* control, ObjectNameResolver* resolver) {
return reinterpret_cast<const HeapSnapshot*>(
reinterpret_cast<i::HeapProfiler*>(this)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
