LGTM
http://codereview.chromium.org/397024/diff/1/3 File src/ia32/disasm-ia32.cc (right): http://codereview.chromium.org/397024/diff/1/3#newcode542 Line 542: case edx: mnem = "rcl"; break; Please change these irrelevant register names to either number constants or specific constants for shift operations, e.g., enum ShiftSubCode { kROL = 0, kROR = 1, kRCL = 2, kRCR = 3, kSHL = 4, KSHR = 5, kSAR = 7 } http://codereview.chromium.org/397024 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
