Reviewers: danno, Michael Starzinger, paul.l..., dusmil.imgtec,
akos.palfi.imgtec, gergely.kis.imgtec,
Description:
MIPS: Simplify pending message script handling.
Port f71e26268338d2840133264329bf35a63011bb5a
Original commit message:
This removes the separate tracking of the pending message script,
because that script is already stored in the message object and
duplicating it in the ThreadLocalTop makes it more brittle.
BUG=
Please review this at https://codereview.chromium.org/999763003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -24 lines):
M src/mips/full-codegen-mips.cc
M src/mips64/full-codegen-mips64.cc
Index: src/mips/full-codegen-mips.cc
diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc
index
48cb3917de5c6dda327161eef10dcd33665c8697..41fd718a5dcc501fc69296032192d7725328cdda
100644
--- a/src/mips/full-codegen-mips.cc
+++ b/src/mips/full-codegen-mips.cc
@@ -5336,12 +5336,6 @@ void FullCodeGenerator::EnterFinallyBlock() {
__ lw(a1, MemOperand(at));
__ SmiTag(a1);
__ push(a1);
-
- ExternalReference pending_message_script =
- ExternalReference::address_of_pending_message_script(isolate());
- __ li(at, Operand(pending_message_script));
- __ lw(a1, MemOperand(at));
- __ push(a1);
}
@@ -5349,12 +5343,6 @@ void FullCodeGenerator::ExitFinallyBlock() {
DCHECK(!result_register().is(a1));
// Restore pending message from stack.
__ pop(a1);
- ExternalReference pending_message_script =
- ExternalReference::address_of_pending_message_script(isolate());
- __ li(at, Operand(pending_message_script));
- __ sw(a1, MemOperand(at));
-
- __ pop(a1);
__ SmiUntag(a1);
ExternalReference has_pending_message =
ExternalReference::address_of_has_pending_message(isolate());
Index: src/mips64/full-codegen-mips64.cc
diff --git a/src/mips64/full-codegen-mips64.cc
b/src/mips64/full-codegen-mips64.cc
index
9ca6e5d07b911f8f097136f995c2e05b23bf8d13..f128a400ba8f00338c56f1ba949e6cdb76806457
100644
--- a/src/mips64/full-codegen-mips64.cc
+++ b/src/mips64/full-codegen-mips64.cc
@@ -5338,12 +5338,6 @@ void FullCodeGenerator::EnterFinallyBlock() {
__ ld(a1, MemOperand(at));
__ SmiTag(a1);
__ push(a1);
-
- ExternalReference pending_message_script =
- ExternalReference::address_of_pending_message_script(isolate());
- __ li(at, Operand(pending_message_script));
- __ ld(a1, MemOperand(at));
- __ push(a1);
}
@@ -5351,12 +5345,6 @@ void FullCodeGenerator::ExitFinallyBlock() {
DCHECK(!result_register().is(a1));
// Restore pending message from stack.
__ pop(a1);
- ExternalReference pending_message_script =
- ExternalReference::address_of_pending_message_script(isolate());
- __ li(at, Operand(pending_message_script));
- __ sd(a1, MemOperand(at));
-
- __ pop(a1);
__ SmiUntag(a1);
ExternalReference has_pending_message =
ExternalReference::address_of_has_pending_message(isolate());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
