2009/11/17 <[email protected]>: > LGTM > > > http://codereview.chromium.org/402008/diff/1/4 > File src/x64/codegen-x64.cc (right): > > http://codereview.chromium.org/402008/diff/1/4#newcode3785 > Line 3785: __ CompareRoot(temp.reg(), Heap::kEmptyStringRootIndex); > Is a memory read really more efficient than an extra opcode that loads > the value as a constant?
It's about the same, but the CompareRoot version makes for more compact code because you avoid the 64 bit inline immediate and the reloc info. > > http://codereview.chromium.org/402008 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
