Thank you for review!
https://codereview.chromium.org/1003663002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1003663002/diff/1/src/api.cc#newcode2678
src/api.cc:2678: bool Value::IsInt32() const { return
Utils::OpenHandle(this)->IsInt32(); }
On 2015/03/12 10:45:58, dcarney wrote:
i don't think v8 cares internally about this distinction, there's no
reason to
push this to objects.cc
Right. Reverted.
https://codereview.chromium.org/1003663002/diff/1/src/api.cc#newcode2960
src/api.cc:2960: Utils::ApiCheck(obj->IsInt32(), "v8::Int32::Cast()",
On 2015/03/12 10:45:58, dcarney wrote:
just use that->IsInt32()
Done.
https://codereview.chromium.org/1003663002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
