Good catch! One nit. LGTM
https://codereview.chromium.org/997423002/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/997423002/diff/1/src/heap/mark-compact.cc#newcode2232
src/heap/mark-compact.cc:2232:
heap()->incremental_marking()->CreateRootMarkingVisitor();
Instead of allocating the incremental root marking visitor and
deallocating it later (and leaking it to a different context), why don't
you create a method in incremental marking that incrementally marks the
object groups with a stack allocated visitor?
Hmm, wait, it feels like this method should be part of incremental
marking. Can we move it there?
https://codereview.chromium.org/997423002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
