LGTM with comments.
https://codereview.chromium.org/1000063002/diff/1/src/string.js
File src/string.js (right):
https://codereview.chromium.org/1000063002/diff/1/src/string.js#newcode940
src/string.js:940: %AddNamedProperty(GlobalString.prototype,
"constructor", GlobalString, DONT_ENUM);
nit: 80col
https://codereview.chromium.org/1000063002/diff/1/src/string.js#newcode943
src/string.js:943: InstallFunctions(GlobalString, DONT_ENUM, $Array(
Why "$Array"? Other files use "var GlobalArray = global.Array" for this;
I assume the "$Array = ..." definition in runtime.js is deprecated.
(again below)
https://codereview.chromium.org/1000063002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
