Reviewers: danno, Sven Panne, titzer,
Message:
PPC port for d4696c484142c601cbd691ae80164043785a3af7 Simplify pending
message
object handling.
Description:
PPC: Simplify pending message object handling.
Port d4696c484142c601cbd691ae80164043785a3af7
Original commit message:
This moves the decision whether to report a message or not to when
the pending exception is propagated instead of trying to preserve the
decision in a ThreadLocalTop field.
[email protected]
Review URL: https://codereview.chromium.org/998943003
Cr-Commit-Position: refs/heads/master@{#27150}
[email protected], [email protected], [email protected]
BUG=
Please review this at https://codereview.chromium.org/1000963002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -14 lines):
M src/ppc/full-codegen-ppc.cc
Index: src/ppc/full-codegen-ppc.cc
diff --git a/src/ppc/full-codegen-ppc.cc b/src/ppc/full-codegen-ppc.cc
index
5cb833a2d15defc3f50538a16fd6b0c94d11a849..2cd6da201a3da656b76980cd20b4aa519f55be53
100644
--- a/src/ppc/full-codegen-ppc.cc
+++ b/src/ppc/full-codegen-ppc.cc
@@ -5330,13 +5330,6 @@ void FullCodeGenerator::EnterFinallyBlock() {
__ mov(ip, Operand(pending_message_obj));
__ LoadP(r4, MemOperand(ip));
__ push(r4);
-
- ExternalReference has_pending_message =
- ExternalReference::address_of_has_pending_message(isolate());
- __ mov(ip, Operand(has_pending_message));
- __ lbz(r4, MemOperand(ip));
- __ SmiTag(r4);
- __ push(r4);
}
@@ -5344,13 +5337,6 @@ void FullCodeGenerator::ExitFinallyBlock() {
DCHECK(!result_register().is(r4));
// Restore pending message from stack.
__ pop(r4);
- __ SmiUntag(r4);
- ExternalReference has_pending_message =
- ExternalReference::address_of_has_pending_message(isolate());
- __ mov(ip, Operand(has_pending_message));
- __ stb(r4, MemOperand(ip));
-
- __ pop(r4);
ExternalReference pending_message_obj =
ExternalReference::address_of_pending_message_obj(isolate());
__ mov(ip, Operand(pending_message_obj));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
