https://codereview.chromium.org/988513003/diff/20001/src/regexp.js
File src/regexp.js (right):
https://codereview.chromium.org/988513003/diff/20001/src/regexp.js#newcode9
src/regexp.js:9: var harmony_regexps = false;
On 2015/03/12 15:47:30, arv wrote:
Why the underscores? JS style is camelCase.
DBC: I think this is acceptable, considering prevalent styles across the
V8 project, which comprises mostly C++ code.
In fact, my personal preference for having consistent style across the
project is so strong that when I write JS or Python code that's checked
into the V8 repo, I like to just follow the C++ style guide (as far as
it can be applied to those languages).
That said, I can see the point that the current mix of styles we have in
*.js files is less than ideal. It doesn't bother me much, though.
I'm sure we could waste a splendid amount of time discussing various
aspects of this issue. (Did I mention that predator pink is the bestest
shed color of all time?)
https://codereview.chromium.org/988513003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
