On 2015/03/12 15:10:33, Yang wrote:
On 2015/03/11 19:28:50, michael_dawson wrote:
> On 2015/03/11 14:59:08, Yang wrote:
> > On 2015/02/25 21:18:54, michael_dawson wrote:
> > > Related to the page size opt, We have just noticed that a recent
change
> > removed
> > > the kBootCodeSizeMultiplier as a tunable and the net is that the
> > > test-heap/FirstPageFitsStartup fails on Power because the test
assumes
the
> > > initial allocations fit into a single page. In our case because of
the
> larger
> > > page size they don't.
> > >
> > > I'm wondering how we should handle this ?
> >
> > test-heap/FirstPageFitsStartup no longer exists. Do you mean
> > test-spaces/SizeOfFirstPageIsLargeEnough? Does it fail due CODE_SPACE
size?
>
> The ones we have seen fail recently that we believe are related include:
>
> cctest/test-strings/OneByteArrayJoin
> cctest/test-spaces/SizeOfFirstPageIsLargeEnough
>
> We do believe they failed because of CODE_SPACE size
I can't reproduce the failures you've seen with 4ededa8694c4 in release
mode.
In case of OneByteArrayJoin, it probably suffices to increase the resource
constraint. For SizeOfFirstPageIsLargeEnough I'd like to be able to
reproduce
it
first.
The logs from buildbot show the failures:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20ppc64%20-%20sim/builds/200/steps/Check/logs/OneByteArrayJoin
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20ppc64%20-%20sim/builds/200/steps/Check/logs/SizeOfFirstPageIsLarg..
Note that this currently shows up in 64-bit only because of its excessive
code
size (due to a lack of constant pool support + another optimization yet to
be
discussed).
https://codereview.chromium.org/910333004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
