LGTM
https://codereview.chromium.org/1005553003/diff/20001/test/mjsunit/es7/object-observe.js
File test/mjsunit/es7/object-observe.js (right):
https://codereview.chromium.org/1005553003/diff/20001/test/mjsunit/es7/object-observe.js#newcode1830
test/mjsunit/es7/object-observe.js:1830: try {
Here is another way to write this:
var ex;
try {
...
} catch (e) {
ex = e;
}
assertInstanceof(ex, TypeError);
assertEquals("Object.observe accept must be an array of strings.",
ex.message);
Then you don't need the return and fail at the end.
https://codereview.chromium.org/1005553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
