Thanks for reviews and for meticulous flagging of all empty flags!
git grep -e 'Flags:\s\+$' tells me there are no more.
Please take another look.
https://codereview.chromium.org/1007783002/diff/40001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/1007783002/diff/40001/src/flag-definitions.h#newcode208
src/flag-definitions.h:208: "harmony classes (implies block scoping &
object literal extension)") \
On 2015/03/13 14:24:32, rossberg wrote:
Update description
Done.
https://codereview.chromium.org/1007783002/diff/40001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1007783002/diff/40001/src/parser.cc#newcode1030
src/parser.cc:1030: if (ok && is_strict(language_mode())) {
On 2015/03/13 14:24:32, rossberg wrote:
Can be merged with previous condition now.
Done.
https://codereview.chromium.org/1007783002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1007783002/diff/40001/src/preparser.h#newcode2943
src/preparser.h:2943: if (is_strict(language_mode()))
On 2015/03/13 14:24:32, rossberg wrote:
Can be merged, too
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-conflicts.js
File test/mjsunit/es6/block-conflicts.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-conflicts.js#newcode5
test/mjsunit/es6/block-conflicts.js:5: // Flags:
On 2015/03/13 14:24:32, rossberg wrote:
Remove line
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-early-errors.js
File test/mjsunit/es6/block-early-errors.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-early-errors.js#newcode28
test/mjsunit/es6/block-early-errors.js:28: // Flags:
On 2015/03/13 14:24:32, rossberg wrote:
Remove line
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-for.js
File test/mjsunit/es6/block-for.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-for.js#newcode28
test/mjsunit/es6/block-for.js:28: // Flags:
On 2015/03/13 14:24:32, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-leave.js
File test/mjsunit/es6/block-leave.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-leave.js#newcode28
test/mjsunit/es6/block-leave.js:28: // Flags:
On 2015/03/13 14:24:32, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-let-declaration.js
File test/mjsunit/es6/block-let-declaration.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-let-declaration.js#newcode28
test/mjsunit/es6/block-let-declaration.js:28: // Flags:
On 2015/03/13 14:24:32, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-let-semantics.js
File test/mjsunit/es6/block-let-semantics.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/block-let-semantics.js#newcode28
test/mjsunit/es6/block-let-semantics.js:28: // Flags:
On 2015/03/13 14:24:32, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/empty-for.js
File test/mjsunit/es6/empty-for.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/empty-for.js#newcode28
test/mjsunit/es6/empty-for.js:28: // Flags:
On 2015/03/13 14:24:32, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/iteration-syntax.js
File test/mjsunit/es6/iteration-syntax.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/es6/iteration-syntax.js#newcode28
test/mjsunit/es6/iteration-syntax.js:28: // Flags:
On 2015/03/13 14:24:32, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-2243.js
File test/mjsunit/regress/regress-2243.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-2243.js#newcode28
test/mjsunit/regress/regress-2243.js:28: // Flags:
On 2015/03/13 14:24:32, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-2322.js
File test/mjsunit/regress/regress-2322.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-2322.js#newcode28
test/mjsunit/regress/regress-2322.js:28: // Flags:
On 2015/03/13 14:24:32, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-2506.js
File test/mjsunit/regress/regress-2506.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-2506.js#newcode5
test/mjsunit/regress/regress-2506.js:5: // Flags:
On 2015/03/13 14:24:33, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-2858.js
File test/mjsunit/regress/regress-2858.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-2858.js#newcode5
test/mjsunit/regress/regress-2858.js:5: // Flags:
On 2015/03/13 14:24:33, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-3426.js
File test/mjsunit/regress/regress-3426.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-3426.js#newcode5
test/mjsunit/regress/regress-3426.js:5: // Flags:
On 2015/03/13 14:24:33, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-3683.js
File test/mjsunit/regress/regress-3683.js (right):
https://codereview.chromium.org/1007783002/diff/40001/test/mjsunit/regress/regress-3683.js#newcode5
test/mjsunit/regress/regress-3683.js:5: // Flags:
On 2015/03/13 14:24:33, rossberg wrote:
Dito
Done.
https://codereview.chromium.org/1007783002/diff/80001/src/parser.cc
File src/parser.cc (left):
https://codereview.chromium.org/1007783002/diff/80001/src/parser.cc#oldcode2251
src/parser.cc:2251: ReportMessage("strict_const");
On 2015/03/13 14:24:33, rossberg wrote:
Remove from message.js as well
Done.
https://codereview.chromium.org/1007783002/diff/80001/test/mjsunit/es6/block-conflicts.js
File test/mjsunit/es6/block-conflicts.js (right):
https://codereview.chromium.org/1007783002/diff/80001/test/mjsunit/es6/block-conflicts.js#newcode5
test/mjsunit/es6/block-conflicts.js:5: // Flags:
On 2015/03/13 14:19:42, arv wrote:
Remove line?
Done.
https://codereview.chromium.org/1007783002/diff/80001/test/mjsunit/es6/block-early-errors.js
File test/mjsunit/es6/block-early-errors.js (right):
https://codereview.chromium.org/1007783002/diff/80001/test/mjsunit/es6/block-early-errors.js#newcode28
test/mjsunit/es6/block-early-errors.js:28: // Flags:
On 2015/03/13 14:19:42, arv wrote:
remove
Done.
https://codereview.chromium.org/1007783002/diff/80001/test/mjsunit/es6/block-for.js
File test/mjsunit/es6/block-for.js (right):
https://codereview.chromium.org/1007783002/diff/80001/test/mjsunit/es6/block-for.js#newcode28
test/mjsunit/es6/block-for.js:28: // Flags:
On 2015/03/13 14:19:43, arv wrote:
etc
Done.
https://codereview.chromium.org/1007783002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
