On 2015/03/14 19:17:34, jarin wrote:
https://codereview.chromium.org/1000883003/diff/1/src/compiler/control-reducer.cc
File src/compiler/control-reducer.cc (right):
https://codereview.chromium.org/1000883003/diff/1/src/compiler/control-reducer.cc#newcode551
src/compiler/control-reducer.cc:551: node1->opcode() ==
IrOpcode::kIfFalse))
&&
On 2015/03/13 18:38:21, brucedawson wrote:
> This test looks wrong. This showed up as a new VC++ /analyze warning:
>
> src\v8\src\objects.cc(2128) : warning C6237: (<zero> && <expression>) is
always
> zero. <expression> is never evaluated and might have side effects.
>
> I'm not sure what the correct check is -- presumably either testing for
both
> being kIfTrue or both being kIfFalse, or else checking for node0/1 being
> kIfTrue/kIfFalse or node0/1 being kIfFalse/kIfTrue. Or maybe something
else.
Good catch. This should test that node0/1 is kIfTrue/kIfFalse or
kIfFalse/kIfTrue.
Indeed, great catch. Thanks.
https://codereview.chromium.org/1000883003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
