Reviewers: jarin,
Description:
[turbofan] Fix obsolete workaround for type system in simplified lowering.
Ranges and bitset types now work together, so we don't need these weird
hacks anymore.
[email protected]
Please review this at https://codereview.chromium.org/994283005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -13 lines):
M src/compiler/simplified-lowering.cc
Index: src/compiler/simplified-lowering.cc
diff --git a/src/compiler/simplified-lowering.cc
b/src/compiler/simplified-lowering.cc
index
1d6320ee3541a88aac7a7e90e024ddd2b835cf58..9a880dbb2e181c6cab8bcdf560750364b4929eb4
100644
--- a/src/compiler/simplified-lowering.cc
+++ b/src/compiler/simplified-lowering.cc
@@ -438,18 +438,8 @@ class RepresentationSelector {
return BothInputsAre(node, Type::Signed32())
&& !CanObserveNonInt32(use);
}
- bool IsSafeIntAdditiveOperand(Node* node) {
- Type* type = NodeProperties::GetBounds(node).upper;
- // TODO(jarin): Unfortunately, bitset types are not subtypes of larger
- // range types, so we have to explicitly check for Integral32 here
- // (in addition to the safe integer range). Once we fix subtyping for
- // ranges, we should simplify this.
- return type->Is(safe_int_additive_range_) ||
type->Is(Type::Integral32());
- }
-
bool CanLowerToInt32AdditiveBinop(Node* node, MachineTypeUnion use) {
- return IsSafeIntAdditiveOperand(node->InputAt(0)) &&
- IsSafeIntAdditiveOperand(node->InputAt(1)) &&
+ return BothInputsAre(node, safe_int_additive_range_) &&
!CanObserveNonInt32(use);
}
@@ -458,8 +448,7 @@ class RepresentationSelector {
}
bool CanLowerToUint32AdditiveBinop(Node* node, MachineTypeUnion use) {
- return IsSafeIntAdditiveOperand(node->InputAt(0)) &&
- IsSafeIntAdditiveOperand(node->InputAt(1)) &&
+ return BothInputsAre(node, safe_int_additive_range_) &&
!CanObserveNonUint32(use);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
