Looks basically sound
https://codereview.chromium.org/1005183006/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/1005183006/diff/1/src/serialize.cc#newcode1875
src/serialize.cc:1875: DCHECK(code_object_);
I don't think you are allowed to use implicit bool conversion.
https://codereview.chromium.org/1005183006/diff/1/src/serialize.cc#newcode1970
src/serialize.cc:1970: if (!(FLAG_enable_ool_constant_pool &&
rinfo->IsInConstantPool())) {
If you don't wipe internal offsets, will snapshots still be
reproducible? This would only be the case if they were always coded in
a relative way, but in that case you didn't need special handling in the
snapshot at all.
https://codereview.chromium.org/1005183006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
