Reviewers: Dirk Pranke, jochen (slow), Michael Achenbach (travelling),
https://codereview.chromium.org/1016923002/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/1016923002/diff/1/BUILD.gn#newcode163
BUILD.gn:163: if (v8_target_arch == "x64") {
Would you like me to change these to else if's?
Description:
Fix the GN build for MIPS.
Define V8_TARGET_ARCH_MIPS or V8_TARGET_ARCH_MIPS64 if the target
arch is mipsel or mips64el.
[email protected],[email protected],[email protected]
BUG=v8:3972
LOG=Y
Please review this at https://codereview.chromium.org/1016923002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+9, -2 lines):
M BUILD.gn
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
509d78afea11a1e700d3fa040092a98c14fa7b68..56fe5179f076a43c794aa5c310a791610f31bdd2
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -33,7 +33,8 @@ v8_toolset_for_d8 = "host"
# x64 Linux host. Eventually we need to support all of the host/target
# configurations v8 runs on.
if (host_cpu == "x64" && host_os == "linux" &&
- (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu
== "x86")) {
+ (target_cpu == "arm" || target_cpu == "mipsel" ||
+ target_cpu == "mips64el" || target_cpu == "x86")) {
snapshot_toolchain = "//build/toolchain/linux:clang_x86"
} else {
snapshot_toolchain = default_toolchain
@@ -113,7 +114,7 @@ config("toolchain") {
defines = []
cflags = []
- # TODO(jochen): Add support for arm subarchs, mips, mipsel.
+ # TODO(jochen): Add support for arm subarchs, mips, mipsel, mips64el.
if (v8_target_arch == "arm") {
defines += [ "V8_TARGET_ARCH_ARM" ]
@@ -150,6 +151,12 @@ config("toolchain") {
if (v8_target_arch == "arm64") {
defines += [ "V8_TARGET_ARCH_ARM64" ]
}
+ if (v8_target_arch == "mipsel") {
+ defines += [ "V8_TARGET_ARCH_MIPS" ]
+ }
+ if (v8_target_arch == "mips64el") {
+ defines += [ "V8_TARGET_ARCH_MIPS64" ]
+ }
if (v8_target_arch == "x86") {
defines += [ "V8_TARGET_ARCH_IA32" ]
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
