I uploaded patch set 2.
https://codereview.chromium.org/1016923002/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/1016923002/diff/1/BUILD.gn#newcode37
BUILD.gn:37: target_cpu == "mips64el" || target_cpu == "x86")) {
On 2015/03/17 21:32:04, Dirk Pranke wrote:
As discussed over chat, I don't think you want this particular change
(it would
build the snapshot using 32-bit pointers, and we need to use 64-bit
pointers for
mips64el).
Done.
https://codereview.chromium.org/1016923002/diff/1/BUILD.gn#newcode117
BUILD.gn:117: # TODO(jochen): Add support for arm subarchs, mips,
mipsel, mips64el.
Jochen, Michael: does it make sense to add "mips64el" to this TODO
comment, or should I revert this change as well?
https://codereview.chromium.org/1016923002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
