Reviewers: Sven Panne,
Description:
[turbofan] Cache Call operator for AllocateHeapNumberStub in change
lowering.
[email protected]
Please review this at https://codereview.chromium.org/1015953002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+11, -6 lines):
M src/compiler/change-lowering.h
M src/compiler/change-lowering.cc
Index: src/compiler/change-lowering.cc
diff --git a/src/compiler/change-lowering.cc
b/src/compiler/change-lowering.cc
index
4806e2bfe1e72414ac86b5d22c44fa7fd3579004..e2aca8ca992b7d4e846f56c629d296a523fabbaa
100644
--- a/src/compiler/change-lowering.cc
+++ b/src/compiler/change-lowering.cc
@@ -64,14 +64,17 @@ Node* ChangeLowering::AllocateHeapNumberWithValue(Node*
value, Node* control) {
// The AllocateHeapNumberStub does not use the context, so we can safely
pass
// in Smi zero here.
Callable callable = CodeFactory::AllocateHeapNumber(isolate());
- CallDescriptor* descriptor = Linkage::GetStubCallDescriptor(
- isolate(), jsgraph()->zone(), callable.descriptor(), 0,
- CallDescriptor::kNoFlags);
Node* target = jsgraph()->HeapConstant(callable.code());
Node* context = jsgraph()->NoContextConstant();
Node* effect = graph()->NewNode(common()->ValueEffect(1), value);
- Node* heap_number = graph()->NewNode(common()->Call(descriptor), target,
- context, effect, control);
+ if (!allocate_heap_number_operator_.is_set()) {
+ CallDescriptor* descriptor = Linkage::GetStubCallDescriptor(
+ isolate(), jsgraph()->zone(), callable.descriptor(), 0,
+ CallDescriptor::kNoFlags);
+ allocate_heap_number_operator_.set(common()->Call(descriptor));
+ }
+ Node* heap_number =
graph()->NewNode(allocate_heap_number_operator_.get(),
+ target, context, effect, control);
Node* store = graph()->NewNode(
machine()->Store(StoreRepresentation(kMachFloat64, kNoWriteBarrier)),
heap_number, HeapNumberValueIndexConstant(), value, heap_number,
control);
Index: src/compiler/change-lowering.h
diff --git a/src/compiler/change-lowering.h b/src/compiler/change-lowering.h
index
3f986399372b7bbfd02578a1ecf93c0ce10fccf2..0d498ccd9760b10d8cfff279f20bacf169f6b4ce
100644
--- a/src/compiler/change-lowering.h
+++ b/src/compiler/change-lowering.h
@@ -16,6 +16,7 @@ class CommonOperatorBuilder;
class JSGraph;
class Linkage;
class MachineOperatorBuilder;
+class Operator;
class ChangeLowering FINAL : public Reducer {
public:
@@ -54,7 +55,8 @@ class ChangeLowering FINAL : public Reducer {
CommonOperatorBuilder* common() const;
MachineOperatorBuilder* machine() const;
- JSGraph* jsgraph_;
+ JSGraph* const jsgraph_;
+ SetOncePointer<const Operator> allocate_heap_number_operator_;
};
} // namespace compiler
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
