Reviewers: fschneider, Message: We need to create a reduced test case from the interactive ui tests. For now I'll disable it so we can push a new version of V8 into chromium trunk.
Description: Disable the fast top-level compiler for non-global declarations. Reintroduce the bailout that was put in in revision 3224. It causes interactive ui test failures in Chromium. [email protected] Please review this at http://codereview.chromium.org/421002 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/compiler.cc Index: src/compiler.cc =================================================================== --- src/compiler.cc (revision 3336) +++ src/compiler.cc (working copy) @@ -646,8 +646,9 @@ void CodeGenSelector::VisitDeclaration(Declaration* decl) { - if (decl->fun() != NULL) { - ProcessExpression(decl->fun(), Expression::kValue); + Variable* var = decl->proxy()->var(); + if (!var->is_global() || var->mode() == Variable::CONST) { + BAILOUT("Non-global declaration"); } } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
