Reviewers: Yang,
Message:
Hi Yang, here is the fix we discussed. Note that I'm not changing the IC
behavior because I'd prefer to keep these changes local to the debugger, and
they are adequate without introducing a new mode to the ICs.
The test is rather involved because it was difficult to prevent the debugger
from clearing ICs until after they'd gone monomorphic. That is why the
breakpoints are set up ahead of time, and why there is a "dummy" breakpoint,
never fired, only used to keep function f1 "present" to the debugger.
--Michael
Description:
Vector ICs: Clear the vector ic slots appropriately during debugging.
When the debugger is active, a host of connected functions get an associated
DebugInfo structure, and their code is copied. The debugger uses the
original
code to occasionally patch ICs with their initial value. Although IC
learning
can occur, it's thrown away often, depending on the constellation of
breakpoints active or deactivating. Finally, feedback is discarded when the
debugger is turned off.
The type feedback vector needs to be brought into line with this behavior,
so
now the debugger clears it's IC slots at appropriate bottlenecks in
debug.cc.
R=yang...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1014373002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+105, -0 lines):
M src/debug.cc
A test/mjsunit/debug-stepframe-clearing.js
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
