There are some issues here, cctest/test-serialize/SerializeInternalReference
fails. But without this CL the build is broken for mips & mips64. So we will
land this as is, and fix it up tomorrow.
lgtm.
https://codereview.chromium.org/1019083002/diff/1/src/mips/assembler-mips-inl.h
File src/mips/assembler-mips-inl.h (right):
https://codereview.chromium.org/1019083002/diff/1/src/mips/assembler-mips-inl.h#newcode205
src/mips/assembler-mips-inl.h:205: if (IsLui(instr_at(pc))) {
This is not correct, we need rmode here to differentiate ENCODED from
normal INTERNAL_REFERENCE.
https://codereview.chromium.org/1019083002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
