https://codereview.chromium.org/1019283002/diff/1/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/1019283002/diff/1/src/messages.js#newcode176
src/messages.js:176: strong_constructor_return_value: ["Please do not
return a value from a constructor in strong mode"],
On 2015/03/19 14:04:11, adamk wrote:
On 2015/03/19 13:59:41, Dmitry Lomov (chromium) wrote:
> Why do we keep pleading with users here?
Drive-by +1 here. The "please" sounds odd for something that's a hard
requirement of the language. That is, it reads more like a deprecation
message
than an error.
Strong mode intentionally has the mostly friendly semantics in the
world. :)
Alright, these should be reformulated. But rather consistently in a
separate CL.
https://codereview.chromium.org/1019283002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1019283002/diff/1/test/cctest/test-parsing.cc#newcode5632
test/cctest/test-parsing.cc:5632: RunParserSyncTest(strong_context_data,
data, kError, NULL, 0, always_flags,
On 2015/03/19 13:59:41, Dmitry Lomov (chromium) wrote:
Please add positive tests for strong mode:
'constructor() { super(); if (x) return; ... }'
etc
We don't have any 'positive' strong mode tests at all, so far. We need
to think about a proper way of ensuring those, but that's also for
separate CL.
https://codereview.chromium.org/1019283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
