LGTM, but please fix the nits.
Yang, can we get your review also please? We can't derive 'encoded' state of
internal ref from the data or address, we have to pass it thru the
serializer.
I've not looked at PPC port to see if this is true for them too. I will try
to
catch up on that.
https://codereview.chromium.org/1025453003/diff/1/src/mips64/assembler-mips64-inl.h
File src/mips64/assembler-mips64-inl.h (right):
https://codereview.chromium.org/1025453003/diff/1/src/mips64/assembler-mips64-inl.h#newcode199
src/mips64/assembler-mips64-inl.h:199: // Encoded internal references
are lui/ori load of 48-bit abolute address.
typo, from my original, s/b: absolute. You might fix the original typo
too (new line 274). Also in the assembler-mips-inl.h
https://codereview.chromium.org/1025453003/diff/1/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/1025453003/diff/1/src/serialize.h#newcode321
src/serialize.h:321: // 0x17 Unused (including 0x37, 0x57, 0x77).
Code 0x17 is now used. I suggest you call this Misc, since that is how
code 1e is labeled & handled.
https://codereview.chromium.org/1025453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
