Reviewers: Hannes Payer,
Description:
Don't DCHECK that the weak closure wasn't yet overapproximated
Maybe it was overapproximated via the idle notification already, so just
don't retry in that case
BUG=chromium:469023
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/1025603003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -2 lines):
M src/heap/heap.cc
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
1b0ab092f04da91374cb07f7d8b46da18aa75e49..054ebced2a899ff2d20941a4d4b76638de122f8a
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -736,8 +736,9 @@ void Heap::HandleGCRequest() {
return;
}
DCHECK(FLAG_overapproximate_weak_closure);
- DCHECK(!incremental_marking()->weak_closure_was_overapproximated());
- OverApproximateWeakClosure("GC interrupt");
+ if (!incremental_marking()->weak_closure_was_overapproximated()) {
+ OverApproximateWeakClosure("GC interrupt");
+ }
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
