Reviewers: Yang,
Description:
Version 4.3.48.2 (cherry-pick)
Merged 877c99f7817c1bc90da8859c105581267dd3e45e
Don't DCHECK that the weak closure wasn't yet overapproximated
BUG=chromium:469023
LOG=N
[email protected]
Please review this at https://codereview.chromium.org/1024853002/
Base URL: https://chromium.googlesource.com/v8/[email protected]
Affected files (+4, -3 lines):
M include/v8-version.h
M src/heap/heap.cc
Index: include/v8-version.h
diff --git a/include/v8-version.h b/include/v8-version.h
index
2e2fe628dbd2687e5db1624fdc845b9ffc9f4f76..45b5ba846f638844241e4ad2cbca5de74274281f
100644
--- a/include/v8-version.h
+++ b/include/v8-version.h
@@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 4
#define V8_MINOR_VERSION 3
#define V8_BUILD_NUMBER 48
-#define V8_PATCH_LEVEL 1
+#define V8_PATCH_LEVEL 2
// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
301b312a79e22812c9685a3693ef09d71d8a5a11..118c002a088b99b02ad7affc93fc23cac430ba9a
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -736,8 +736,9 @@ void Heap::HandleGCRequest() {
return;
}
DCHECK(FLAG_overapproximate_weak_closure);
- DCHECK(!incremental_marking()->weak_closure_was_overapproximated());
- OverApproximateWeakClosure("GC interrupt");
+ if (!incremental_marking()->weak_closure_was_overapproximated()) {
+ OverApproximateWeakClosure("GC interrupt");
+ }
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
