STV (with comments)
http://codereview.chromium.org/436001/diff/2001/2023 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/436001/diff/2001/2023#newcode113 src/arm/ic-arm.cc:113: __ add(t1, t1, Operand(StringDictionary::GetProbeOffset(i))); If you add the probe offset shifted left here then you can omit the LSR above and instead put it in the and instruction below. http://codereview.chromium.org/436001/diff/2001/2022 File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/436001/diff/2001/2022#newcode232 src/arm/stub-cache-arm.cc:232: __ ldr(r0, FieldMemOperand(receiver, String::kLengthOffset)); isn't this already smi tagged? http://codereview.chromium.org/436001/diff/2001/2006 File src/heap.cc (right): http://codereview.chromium.org/436001/diff/2001/2006#newcode1847 src/heap.cc:1847: cons_string->set_hash_field(0); we should have a constant that means hash not yet calculated http://codereview.chromium.org/436001/diff/2001/2006#newcode2618 src/heap.cc:2618: // Set length and hash field of the allocated string. field -> fields http://codereview.chromium.org/436001/diff/2001/2006#newcode2655 src/heap.cc:2655: String::cast(result)->set_hash_field(0); And here http://codereview.chromium.org/436001/diff/2001/2006#newcode2683 src/heap.cc:2683: String::cast(result)->set_hash_field(0); And here http://codereview.chromium.org/436001/diff/2001/2025 File src/heap.h (right): http://codereview.chromium.org/436001/diff/2001/2025#newcode74 src/heap.h:74: V(Map, undetectable_string_map, UndetectableShortStringMap) \ why are these still short? http://codereview.chromium.org/436001/diff/2001/2016 File src/utils.h (right): http://codereview.chromium.org/436001/diff/2001/2016#newcode588 src/utils.h:588: int TenToThe(int exponent); Is this used with a non-constant exponent. For constant exponents the 1e5 notation is more compact and simpler. http://codereview.chromium.org/436001/diff/2001/2019 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/436001/diff/2001/2019#newcode3772 src/x64/codegen-x64.cc:3772: // Check for index out of range. Looks like you can omit the movl and just put the field operand in the cmpl http://codereview.chromium.org/436001 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
