lgtm
https://codereview.chromium.org/1018043003/diff/1/test/mjsunit/harmony/rest-params.js
File test/mjsunit/harmony/rest-params.js (right):
https://codereview.chromium.org/1018043003/diff/1/test/mjsunit/harmony/rest-params.js#newcode188
test/mjsunit/harmony/rest-params.js:188: constructor(...a) { this.base =
a; }
On 2015/03/20 13:28:40, caitp wrote:
On 2015/03/20 08:32:46, Dmitry Lomov (chromium) wrote:
> Please add tests that validate 'arguments' behavior in these cases.
You mean, assert that the arguments elements are identical to the rest
parameter
elements? Or the restriction on "caller" / "callee" etc
--- added more to the test for the first part
First part is what I meant - since you indirectly modified code related
to 'arguments' object buiilding
https://codereview.chromium.org/1018043003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
