Reviewers: Weiliang,
Message:
PTAL.
Description:
X87: Simplify pending message script handling.
port f71e26268338d2840133264329bf35a63011bb5a (r27127)
original commit message:
Simplify pending message script handling.
This removes the separate tracking of the pending message script,
because that script is already stored in the message object and
duplicating it in the ThreadLocalTop makes it more brittle.
BUG=
Please review this at https://codereview.chromium.org/1028993003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -10 lines):
M src/x87/full-codegen-x87.cc
Index: src/x87/full-codegen-x87.cc
diff --git a/src/x87/full-codegen-x87.cc b/src/x87/full-codegen-x87.cc
index
d375975e727d2b9e14cfe872ce5f212efc9f499e..719da95846ec26f7ae692c0b8355fdc2c0cccdee
100644
--- a/src/x87/full-codegen-x87.cc
+++ b/src/x87/full-codegen-x87.cc
@@ -5243,11 +5243,6 @@ void FullCodeGenerator::EnterFinallyBlock() {
__ mov(edx, Operand::StaticVariable(has_pending_message));
__ SmiTag(edx);
__ push(edx);
-
- ExternalReference pending_message_script =
- ExternalReference::address_of_pending_message_script(isolate());
- __ mov(edx, Operand::StaticVariable(pending_message_script));
- __ push(edx);
}
@@ -5255,11 +5250,6 @@ void FullCodeGenerator::ExitFinallyBlock() {
DCHECK(!result_register().is(edx));
// Restore pending message from stack.
__ pop(edx);
- ExternalReference pending_message_script =
- ExternalReference::address_of_pending_message_script(isolate());
- __ mov(Operand::StaticVariable(pending_message_script), edx);
-
- __ pop(edx);
__ SmiUntag(edx);
ExternalReference has_pending_message =
ExternalReference::address_of_has_pending_message(isolate());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
