LGTM with comments.
https://codereview.chromium.org/1028093002/diff/40001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/1028093002/diff/40001/src/arm/code-stubs-arm.cc#newcode2919
src/arm/code-stubs-arm.cc:2919: __
push(VectorLoadICDescriptor::VectorRegister());
If you use Push to push both registers at once, you may end up with a
shorter instruction if you use the correct order.
https://codereview.chromium.org/1028093002/diff/40001/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (right):
https://codereview.chromium.org/1028093002/diff/40001/src/arm64/code-stubs-arm64.cc#newcode3331
src/arm64/code-stubs-arm64.cc:3331: __
Pop(VectorLoadICDescriptor::SlotRegister());
Can we use the equivalent Pop with two registers?
https://codereview.chromium.org/1028093002/diff/40001/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):
https://codereview.chromium.org/1028093002/diff/40001/src/mips/code-stubs-mips.cc#newcode3087
src/mips/code-stubs-mips.cc:3087: __
pop(VectorLoadICDescriptor::VectorRegister());
Same here, corresponding Pop?
https://codereview.chromium.org/1028093002/diff/40001/test/mjsunit/string-index.js
File test/mjsunit/string-index.js (right):
https://codereview.chromium.org/1028093002/diff/40001/test/mjsunit/string-index.js#newcode255
test/mjsunit/string-index.js:255: var keys = [0, Math.abs(2)];
You probably should check that this is not a smi via %IsSmi
https://codereview.chromium.org/1028093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
