Reviewers: jochen (slow),
Message:
PTAL. This fixes the race for interrupt flags, but doesn't fix the benign
race
for climit.
Description:
Acquire a lock before checking for GC interrupt in JSON parser.
BUG=
Please review this at https://codereview.chromium.org/1025333002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -0 lines):
M src/json-parser.h
Index: src/json-parser.h
diff --git a/src/json-parser.h b/src/json-parser.h
index
7cf80966dfd18d317d61c6ff2e34ee7d38c09fa3..1a9a36f283513bab2f3b72d2d6e5a78c6d0d2de8
100644
--- a/src/json-parser.h
+++ b/src/json-parser.h
@@ -262,6 +262,7 @@ Handle<Object>
JsonParser<seq_one_byte>::ParseJsonValue() {
}
if (isolate_->stack_guard()->InterruptRequested()) {
+ ExecutionAccess access(isolate_);
// Avoid blocking GC in long running parser (v8:3974).
isolate_->stack_guard()->CheckAndHandleGCInterrupt();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
