On 2015/03/23 15:11:14, wingo wrote:
Some nits. Regarding the log, LOG=N I think as it's just a refactor, and
do
remove the bits about changes that aren't included. Remove the last para
too
as
it just restates the google c++ style guide.
Ack.
https://codereview.chromium.org/1024703004/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/1024703004/diff/1/src/arm/full-codegen-arm.cc#newcode130
src/arm/full-codegen-arm.cc:130: info->scope()->has_this_declaration()) {
This will change the behavior of "this" scoping in arrow functions
already,
no?
And not yet to the correct behavior. If this is the case, please remove
the
codegen changes from this patch; we'll include them in the next one.
Ack.
Right, this changes the for arrow functions. The updated version has
Scope::has_this_declaration(), and the codegen changes removed. Now it
is only the cleanups, without any addition.
https://codereview.chromium.org/1024703004/diff/1/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1024703004/diff/1/src/scopes.h#newcode349
src/scopes.h:349: bool has_this_declaration() const {
Given that we won't include the codegen changes in this one, probably
should
punt this bit too as it's not used.
Ack.
https://codereview.chromium.org/1024703004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
