On 2015/03/23 17:53:09, chunyang.dai wrote:
On 2015/03/23 17:42:49, Dmitry Lomov (chromium) wrote:
>
https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x87.cc
> File src/x87/code-stubs-x87.cc (left):
>
>
https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x87.cc#oldcode4325
> src/x87/code-stubs-x87.cc:4325: __ cmp(edx, edi);
> Why this comparison and branch got removed?
> The label 'subclassing' is never reached.
There is a comparison at line 4317. One branch target is subclassing.
right?
This patch for X87 is totally ported from IA32.
Ah right, sorry, missed that.
lgtm
https://codereview.chromium.org/1019353006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
