https://codereview.chromium.org/1021713005/diff/20001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/1021713005/diff/20001/src/compiler.cc#newcode421
src/compiler.cc:421: } else if (FLAG_turbo_type_feedback) {
Can we please move this into the CompilationInfo constructor?
https://codereview.chromium.org/1021713005/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1021713005/diff/20001/src/compiler/ast-graph-builder.cc#newcode1938
src/compiler/ast-graph-builder.cc:1938: BuildNamedLoad(object, name,
pair, expr->AssignmentFeedbackId());
Shouldn't the property loads in the assignment use
property->PropertyFeedbackId() here?
https://codereview.chromium.org/1021713005/diff/20001/src/compiler/ast-graph-builder.cc#newcode1949
src/compiler/ast-graph-builder.cc:1949: BuildKeyedLoad(object, key,
pair, expr->AssignmentFeedbackId());
Likewise.
https://codereview.chromium.org/1021713005/diff/20001/src/compiler/ast-graph-builder.h
File src/compiler/ast-graph-builder.h (right):
https://codereview.chromium.org/1021713005/diff/20001/src/compiler/ast-graph-builder.h#newcode25
src/compiler/ast-graph-builder.h:25: class JSTypeFeedbackTable;
nit: Please alpha-sort.
https://codereview.chromium.org/1021713005/diff/20001/src/compiler/ast-graph-builder.h#newcode271
src/compiler/ast-graph-builder.h:271: const VectorSlotPair& feedback,
TypeFeedbackId id);
suggestion: Would it make sense to make TypeFeedbackId::None() a default
argument for all four of these methods?
https://codereview.chromium.org/1021713005/diff/20001/src/compiler/node-properties.h
File src/compiler/node-properties.h (right):
https://codereview.chromium.org/1021713005/diff/20001/src/compiler/node-properties.h#newcode85
src/compiler/node-properties.h:85: static void MergeControlToEnd(Graph*
graph, CommonOperatorBuilder* common,
Can we get a short comment explaining the intent of this method?
https://codereview.chromium.org/1021713005/diff/20001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/1021713005/diff/20001/src/compiler/pipeline.cc#newcode271
src/compiler/pipeline.cc:271: JSTypeFeedbackTable* js_type_feedback_;
nit: If the feedback table lives in this block, it should be set to NULL
in PipelineData::DeleteGraphZone as well.
https://codereview.chromium.org/1021713005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
