Reviewers: Yang, kozyatinskiy,
Message:
Created Revert of [V8] Removed SourceLocationRestrict
Description:
Revert of [V8] Removed SourceLocationRestrict (patchset #3 id:40001 of
https://codereview.chromium.org/1022333004/)
Reason for revert:
[Sheriff] This seems to change layout test expectations of some tests, e.g.:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2317
Expectation example:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/2317/layout-test-results/fast/events/window-onerror-11-pretty-diff.html
Please add a needsmanualrebaseline expectation to the tests affected by this
change on the blink side first before relanding.
Original issue's description:
[V8] Removed SourceLocationRestrict
This method uses in messages.js in GetSourceLine and GetPositionInLine.
This
methods uses in v8::Message API methods and there is no documentation about
it.
Method looks obsolete.
One of the strange side effect is shown by attached issue.
BUG=chromium:468781
[email protected]
LOG=Y
Committed: https://crrev.com/b563ceac0f95551a128a1403cdbacc7aefcdabaf
Cr-Commit-Position: refs/heads/master@{#27374}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:468781
Please review this at https://codereview.chromium.org/1028413002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+143, -4 lines):
M src/messages.js
M test/mjsunit/debug-sourceinfo.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
