Reviewers: Søren Gjesse, Description: Include getters and setters callbacks invocations in CPU profiler log.
Logging getters and setters to DOM is extremely useful for web developers as setting (and getting!) several properties can cause page relayouts which take significant time. Additional hassle with getter and setter callbacks (as opposed to function callbacks) is due to the fact that they allow the same callback function to be reused for handling different fields. That's why I've put logging of (name, address) pair on every callback invocation. This is not a problem when log compression is used, because all those repetitive entries are get happily squeezed into one record. As a consequence, I've introduced a special CodeEntry type into tick processor to avoid unneeded objects creation. Please review this at http://codereview.chromium.org/434074 Affected files: M src/log.h M src/log.cc M src/stub-cache.cc M test/mjsunit/tools/codemap.js M tools/codemap.js M tools/profile.js M tools/tickprocessor.js --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
