We should find a way to avoid calls to logger for each getter/setter callback. Don't you have the same problem of using the same callback function for several functions as well? What about interceptors?
http://codereview.chromium.org/434074/diff/1/3 File src/log.h (right): http://codereview.chromium.org/434074/diff/1/3#newcode211 src/log.h:211: static void GetCallbackEvent(String* name, Address entry_point); How about GetCallbackEvent -> GetterCallbackEvent? http://codereview.chromium.org/434074/diff/1/3#newcode212 src/log.h:212: static void SetCallbackEvent(String* name, Address entry_point); and SetCallbackEvent -> SetterCallbackEvent? http://codereview.chromium.org/434074/diff/1/4 File src/stub-cache.cc (right): http://codereview.chromium.org/434074/diff/1/4#newcode755 src/stub-cache.cc:755: LOG(GetCallbackEvent(*name, getter_address)); Even though this is caught by the log compression I don't like having a call to the logger in this code-path - it is a quite hot piece of code in some situations. Would it be possible to add the name the VMState instead? It might require additional handling of VMState chain during GC, but it has a much less overhead - and predictable overhaea as well. However as the name is in a handle on the stack here sticking the raw pointer into the VMState should be safe... http://codereview.chromium.org/434074 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
