Just one main comment about the factory.cc change.
https://codereview.chromium.org/998253005/diff/20001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/998253005/diff/20001/src/debug.cc#newcode2106
src/debug.cc:2106: SharedFunctionInfo* s = function->shared();
nit: s/s/shared/ here.
https://codereview.chromium.org/998253005/diff/20001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/998253005/diff/20001/src/factory.cc#newcode1357
src/factory.cc:1357: info->allows_lazy_compilation() &&
!info->optimization_disabled();
Is this additional part of the predicate necessary for correctness? I am
not a big fan of this early checks throughout the code and would like to
consolidate those in compiler.cc as much as possible.
https://codereview.chromium.org/998253005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
