Reviewers: mtbrandyberry, Sven Panne,
Message:
Next PPC port, included Sven because there are changes to the common test
excludes file.
Description:
PPC: Ensure predictable code size at map_check in
LCodeGen::DoInstanceOfKnownGlobal.
[email protected], [email protected]
BUG=
Please review this at https://codereview.chromium.org/1035723003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -6 lines):
M src/ppc/lithium-codegen-ppc.cc
M test/mjsunit/mjsunit.status
Index: src/ppc/lithium-codegen-ppc.cc
diff --git a/src/ppc/lithium-codegen-ppc.cc b/src/ppc/lithium-codegen-ppc.cc
index
207075534c32ce0e32851eb5a1b3708ed9157f29..f6147c2196eef20480bbcc2ab3bc485b0603d751
100644
--- a/src/ppc/lithium-codegen-ppc.cc
+++ b/src/ppc/lithium-codegen-ppc.cc
@@ -2885,7 +2885,7 @@ void
LCodeGen::DoInstanceOfKnownGlobal(LInstanceOfKnownGlobal* instr) {
Register map = temp;
__ LoadP(map, FieldMemOperand(object, HeapObject::kMapOffset));
{
- // Block constant pool emission to ensure the positions of
instructions are
+ // Block trampoline emission to ensure the positions of instructions
are
// as expected by the patcher. See InstanceofStub::Generate().
Assembler::BlockTrampolinePoolScope block_trampoline_pool(masm_);
__ bind(deferred->map_check()); // Label for calculating code
patching.
@@ -2896,7 +2896,7 @@ void
LCodeGen::DoInstanceOfKnownGlobal(LInstanceOfKnownGlobal* instr) {
__ mov(ip, Operand(cell));
__ LoadP(ip, FieldMemOperand(ip, Cell::kValueOffset));
__ cmp(map, ip);
- __ bne(&cache_miss);
+ __ bc_short(ne, &cache_miss);
// We use Factory::the_hole_value() on purpose instead of loading from
the
// root array to force relocation to be able to later patch
// with true or false.
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
885f7e09639bf5b40dcc864c1aa6a1d09a46e489..d21e5948a347558da79c787a25e3269bc240d752
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -606,9 +606,5 @@
# take too long with the simulator.
'regress/regress-1132': [SKIP],
-
- # these two issues started after uplevel, believe they share common cause
- 'debug-references': [SKIP],
- 'mirror-object': [SKIP],
}], # 'arch == ppc and simulator_run == True'
]
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
