https://codereview.chromium.org/1027283004/diff/350001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/1027283004/diff/350001/src/factory.cc#newcode1273
src/factory.cc:1273: Handle<Map> map = use_empty_function_map
On 2015/03/26 13:00:17, caitp wrote:
On 2015/03/26 12:46:43, arv wrote:
> What does "empty function" mean here? It does not fit the actual
code very
well.
originally I was saving the map of the empty function in here --- I
guess
"strict" works too though, maybe more clearly
strict sounds more correct here.
https://codereview.chromium.org/1027283004/diff/350001/src/factory.cc#newcode1286
src/factory.cc:1286: ? isolate()->strict_function_map()
On 2015/03/26 13:00:17, caitp wrote:
On 2015/03/26 12:46:43, arv wrote:
> Is there no strict function with readonly prototype?
well, technically strict_function_map() IS a readonly prototype ---
the writable
prototype version is only kept around in the bootstrapper, though
Maybe add a DCHECK to make sure we don't get the invalid case here?
https://codereview.chromium.org/1027283004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
